@Kai sent you another PR which fixed a few issues.
the main thing is… you cannot have VST2 support using the embedded JUCE vst3 sdk.
so for now, Ive taken it out.
Ive also removed some of the redundant code, that Id left in form when Id previously being using VST2 instead of vst3… makes things a lot simpler
if you want VST2 support, then we’d need to add back the custom vst2_sdk path.
but I would also make the VST2 build optional, so by default the build does NOT require this sdk.
though, personally, Id not bother… for my vst projects, Im going to go remove all the vst2 stuff
also, ive changed it so the build defaults to a universal build rather than forces it.
(sometimes its handy to force a single architecture build)
I didnt change this… as this was a deliberate choice on your part …
but personally, id not included a version in the binary name.
this could cause potential issues with VSTs and host
the host uses the plugin code - not the filename, which if a user does not remove the old version, will now have 2 plugins.
also frankly, as a user I always prefer to just overwrite old versions with new versions of plugins and apps… if Im ‘concerned’, I will manually take a copy of the old version if I feel its necessary.
anyway… just my personal opinion, so Ive not changed it.
on my side, given the cmake universal build is working here…
I’ll consider converting my stack (MEC,EigenLite and libpicodecoder) all to universal binaries.
note:
this will be universal 2, so I believe thats only 64bit arm/intel, so no 32bit intel support…
note 2:
I wont actively remove 32bit support, but just wont distribute/support it.
so someone can build it themselves if they have the need for it.